-
Notifications
You must be signed in to change notification settings - Fork 16
New landing page design #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview the changes: https://turinglang.org/pr-previews/119 |
If anyone is interested, then please feel free to take on this PR! |
* very basic redesign * make buttons interactive
* add dangling code example * add code example section
* quickfix alignment * add news and clean up scss
* improve colors * better link hover color
* paste in svg * responsive svg header
using the same background colour for the team "cards" as for the non-hoverable cards on the landing page
- added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
0046a57
to
e9e14d5
Compare
I will definitely have time to finish this in July. Which points would you like to see addressed before this PR can be merged? |
Revisiting this. Is there a reason why the old PR was closed? Also, I'd personally be happy to merge if some of the placeholder content is removed. Honestly, it's not like the existing front page has any resources, so even a fairly clean slate would be a huge improvement over the current one. |
I have updated docs site PR (TuringLang/docs#613) with SCSS rules that @simonsteiger added in this site! |
It's looking great so let's stick with it! |
6409083
to
8a9ebbc
Compare
Thanks a lot @simonsteiger! Great work — really appreciate your efforts and attention to detail 🙌! |
Thanks a lot, I'm happy that you like it! I'm happy to be able to give back to a project that I've benefited a lot from myself! I just checked the docs site PR (TuringLang/docs#613) and felt that the code panel background has suboptimal contrast in dark mode. I guess the procedure of porting the changes between repos is a bit tedious, but let me know @shravanngoswamii if you'd be interested in me having a go at trying to improve these. I didn't have that on my mental map because there's currently no code block on the landing page (or of course News / Team pages). |
Hii @simonsteiger, thanks for help! Please feel free to push in both PRs! |
In general I think it looks amazing! |
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
…nglang.github.io into new-landing-page
@simonsteiger Let's merge it, can you please review it once more before merging! |
@simonsteiger, These might help -- https://quarto.org/docs/output-formats/html-themes.html#code-blocks and this: turinglang.github.io/_quarto.yml Line 56 in 9f043c6
|
Continuing #105
Preview the changes: https://turinglang.org/pr-previews/119